Messages in this thread | | | Date | Wed, 3 Jun 2009 16:33:25 +0200 | Subject | Re: [PATCH 1/5] topology: introduce cpu_node information for multi-node processors | From | Bert Wesarg <> |
| |
On Wed, Jun 3, 2009 at 16:29, Andreas Herrmann <andreas.herrmann3@amd.com> wrote: > > New topology attributes are > - cpu_node_id (id of the internal node) > - cpu_node_siblings and cpu_node_siblings_list > (siblings on the same internal node) Looks good. Thank you.
Acked-by: Bert.Wesarg@googlemail.com
> > Signed-off-by: Andreas Herrmann <andreas.herrmann3@amd.com> > --- > drivers/base/topology.c | 10 ++++++++++ > include/linux/topology.h | 9 +++++++++ > 2 files changed, 19 insertions(+), 0 deletions(-) > > diff --git a/drivers/base/topology.c b/drivers/base/topology.c > index bf6b132..1e35a43 100644 > --- a/drivers/base/topology.c > +++ b/drivers/base/topology.c > @@ -103,6 +103,9 @@ static ssize_t show_##name##_list(struct sys_device *dev, \ > define_id_show_func(physical_package_id); > define_one_ro(physical_package_id); > > +define_id_show_func(cpu_node_id); > +define_one_ro(cpu_node_id); > + > define_id_show_func(core_id); > define_one_ro(core_id); > > @@ -110,6 +113,10 @@ define_siblings_show_func(thread_cpumask); > define_one_ro_named(thread_siblings, show_thread_cpumask); > define_one_ro_named(thread_siblings_list, show_thread_cpumask_list); > > +define_siblings_show_func(cpu_node_cpumask); > +define_one_ro_named(cpu_node_siblings, show_cpu_node_cpumask); > +define_one_ro_named(cpu_node_siblings_list, show_cpu_node_cpumask_list); > + > define_siblings_show_func(core_cpumask); > define_one_ro_named(core_siblings, show_core_cpumask); > define_one_ro_named(core_siblings_list, show_core_cpumask_list); > @@ -119,6 +126,9 @@ static struct attribute *default_attrs[] = { > &attr_core_id.attr, > &attr_thread_siblings.attr, > &attr_thread_siblings_list.attr, > + &attr_cpu_node_id.attr, > + &attr_cpu_node_siblings.attr, > + &attr_cpu_node_siblings_list.attr, > &attr_core_siblings.attr, > &attr_core_siblings_list.attr, > NULL > diff --git a/include/linux/topology.h b/include/linux/topology.h > index 7402c1a..976a130 100644 > --- a/include/linux/topology.h > +++ b/include/linux/topology.h > @@ -180,6 +180,9 @@ int arch_update_cpu_topology(void); > #ifndef topology_physical_package_id > #define topology_physical_package_id(cpu) ((void)(cpu), -1) > #endif > +#ifndef topology_cpu_node_id > +#define topology_cpu_node_id(cpu) ((void)(cpu), 0) > +#endif > #ifndef topology_core_id > #define topology_core_id(cpu) ((void)(cpu), 0) > #endif > @@ -189,12 +192,18 @@ int arch_update_cpu_topology(void); > #ifndef topology_core_siblings > #define topology_core_siblings(cpu) cpumask_of_cpu(cpu) > #endif > +#ifndef topology_cpu_node_siblings > +#define topology_cpu_node_siblings(cpu) topology_core_siblings(cpu) > +#endif > #ifndef topology_thread_cpumask > #define topology_thread_cpumask(cpu) cpumask_of(cpu) > #endif > #ifndef topology_core_cpumask > #define topology_core_cpumask(cpu) cpumask_of(cpu) > #endif > +#ifndef topology_cpu_node_cpumask > +#define topology_cpu_node_cpumask(cpu) topology_core_cpumask(cpu) > +#endif > > /* Returns the number of the current Node. */ > #ifndef numa_node_id > -- > 1.6.3.1 > > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |