Messages in this thread | | | Date | Wed, 3 Jun 2009 13:24:56 +0200 | From | Andi Kleen <> | Subject | Re: [PATCH] [13/16] HWPOISON: The high level memory error handler in the VM v3 |
| |
On Wed, Jun 03, 2009 at 11:35:46AM +0200, Nick Piggin wrote: > On Tue, Jun 02, 2009 at 07:27:15PM +0200, Andi Kleen wrote: > > > Hmm, if you're handling buffercache here then possibly yes. > > > > Good question, will check. > > BTW. now that I think about it, buffercache is probably not a good > idea to truncate (truncate, as-in: remove from pagecache). Because > filesystems can assume that with just a reference on the page, then > it will not be truncated.
Yes I understand. Need to check for this, but I'm not sure how we can reliably detect it based on the struct page alone. I guess we have to look at the mapping.
> So I think it would be a good idea to exclude buffercache from > here completely until it can be shown to be safe. Actually you
Agreed. Just need to figure out how.
-Andi
-- ak@linux.intel.com -- Speaking for myself only.
| |