lkml.org 
[lkml]   [2009]   [Jun]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] [13/16] HWPOISON: The high level memory error handler in the VM v3
    On Tue, Jun 02, 2009 at 07:27:15PM +0200, Andi Kleen wrote:
    > > Hmm, if you're handling buffercache here then possibly yes.
    >
    > Good question, will check.

    BTW. now that I think about it, buffercache is probably not a good
    idea to truncate (truncate, as-in: remove from pagecache). Because
    filesystems can assume that with just a reference on the page, then
    it will not be truncated.

    This code will cause ext2 (as the first one I looked at), to go
    oops.

    And this is not predicated on PagePrivate or page_has_buffers,
    because filesystems are free to directly operate on their own
    metadata buffercache pages.

    So I think it would be a good idea to exclude buffercache from
    here completely until it can be shown to be safe. Actually you
    *can* use the invalidate_mapping_pages path, which will check
    refcounts etc (or a derivative thereof, similarly to my truncate
    patch).




    \
     
     \ /
      Last update: 2009-06-03 11:41    [W:0.019 / U:129.684 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site