Messages in this thread | | | Date | Mon, 29 Jun 2009 11:34:13 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH] net: fix race in the receive/select |
| |
On Fri, Jun 26, 2009 at 09:35:28PM +0200, Eric Dumazet wrote: > David Miller a écrit : > > From: Davide Libenzi <davidel@xmailserver.org> > > Date: Fri, 26 Jun 2009 11:12:15 -0700 (PDT) > > > >> On Fri, 26 Jun 2009, Oleg Nesterov wrote: > >> > >>> Perhaps we can add > >>> > >>> void sock_poll_wait(struct file *file, struct sock *sk, poll_table *pt) > >>> { > >>> if (pt) { > >>> poll_wait(file, sk->sk_sleep, pt); > >>> /* > >>> * fat comment > >>> */ > >>> smp_mb(); // or smp_mb__after_unlock(); > >>> } > >>> } > >> That'd be fine IMHO. Are DaveM and Eric OK? > > > > No objections from me. > > Very good :) > > Jiri, please respin a patch with this idea from Oleg > > (We'll have to check all calls to poll_wait() in net tree) > > Thanks everybody >
thanks a lot! :) I'll send out new patch shortly..
I'll include all the poll_wait calls change I'm kind of sure of, and list of others I'm not, so we can discuss them.
jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |