[lkml]   [2009]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] exec: Make do_coredump more robust and safer when using pipes in core_pattern
On Sun, Jun 28, 2009 at 03:06:25PM -0700, Eric W. Biederman wrote:
> Andi Kleen <> writes:
> >> Andrew should I toss all 100 or so patches over the wall to you
> >> and your -mm tree? Or should I maintain a public git tree based
> >> at 2.6.31-rc1? Get it into linux-next and ask Linus to pull it when
> >> the merge window comes?
> >
> > What do these 100 odd patches do exactly?
> Mostly a fine grained killing of ctl_name, and strategy.


The only issue is -- assuming we convert that over to DEFINE_SYSCTL
too (which I think would be much nicer) all tee maintainers would
need to process two patches. So perhaps it would be better to combine
this into a single update?

> > Then the binary sysctls could be handled by a global table
> > in a separate file like you described
> Getting the binary sysctl crud out of the core path should
> happen first. That is just a handful of patches.

Agreed. It should be just a separate table.

> > the current interfaces are not great, but could be probably kept.
> Things like register_sysctl_path can be greatly improved. Now
> that we don't have to worry about the binary paths.

With a module DEFINE_SYSCTL() only truly dynamic sysctls (like
the network per device sysctls) would need that anyways; the
far majority of callers wouldn't need to call any functions.

-- -- Speaking for myself only.

 \ /
  Last update: 2009-06-29 11:17    [W:0.073 / U:1.376 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site