[lkml]   [2009]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [BUG 2.6.31-rc1] HIGHMEM64G causes hang in PCI init on 32-bit x86
Linus Torvalds wrote:
> ...
> end = round_up(start, ram_alignment(start)) - 1;
> if (end > MAX_RESOURCE_SIZE)
> if (start > end)
> continue;
> Because otherwise we'll just be ignoring resources that cross the resource
> size boundary, which sounds wrong.
> We _could_ have a RAM resource that crosses the 4GB boundary, after all.

We could, but the *alignment pad* shouldn't be able to cross a
power-of-two boundary ("end" is always an aligned-up version of "start").

> That said, I have to admit that I'm getting tired of these bugs that only
> happen when we have a 32-bit resource_size_t. So I can understand the
> attraction to just forcing it to 64-bit and forgetting about these
> irritating issues.

Probably would be worth figuring out just how much it would be.


H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.

 \ /
  Last update: 2009-06-30 03:47    [W:0.090 / U:8.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site