lkml.org 
[lkml]   [2009]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: + alpha-fix-percpu-build-breakage.patch added to -mm tree
On Sat, 27 Jun 2009, akpm@linux-foundation.org wrote:

>
> The patch titled
> alpha: fix percpu build breakage
> has been added to the -mm tree. Its filename is
> alpha-fix-percpu-build-breakage.patch
>
> Before you just go and hit "reply", please:
> a) Consider who else should be cc'ed
> b) Prefer to cc a suitable mailing list as well
> c) Ideally: find the original patch on the mailing list and do a
> reply-to-all to that, adding suitable additional cc's
>
> *** Remember to use Documentation/SubmitChecklist when testing your code ***
>
> See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
> out what to do about this
>
> The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
>
> ------------------------------------------------------
> Subject: alpha: fix percpu build breakage
> From: Tejun Heo <tj@kernel.org>
>
> alpha percpu access requires custom SHIFT_PERCPU_PTR() definition for
> modules to work around addressing range limitation. This is done via
> generating inline assembly using C preprocessing which forces the
> assembler to generate external reference. This happens behind the
> compiler's back and makes the compiler think that static percpu variables
> in modules are unused.
>
> This used to be worked around by using __unused attribute for percpu
> variables which prevent the compiler from omitting the variable; however,
> recent declare/definition attribute unification change broke this as
> __used can't be used for declaration. Also, in the process,
> PER_CPU_ATTRIBUTES definition in alpha percpu.h got broken.
>
> This patch adds PER_CPU_DEF_ATTRIBUTES which is only used for definitions
> and make alpha use it to add __used for percpu variables in modules. This
> also fixes the PER_CPU_ATTRIBUTES double definition bug.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Cc: maximilian attems <max@stro.at>
> Cc: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
> Cc: Richard Henderson <rth@twiddle.net>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
> arch/alpha/include/asm/percpu.h | 6 +++---
> include/asm-generic/percpu.h | 4 ++++
> include/linux/percpu-defs.h | 3 ++-
> 3 files changed, 9 insertions(+), 4 deletions(-)

verified that all Debian alpha images build fine with aboves patch.
thanks.


\
 
 \ /
  Last update: 2009-06-30 01:01    [W:0.027 / U:2.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site