lkml.org 
[lkml]   [2009]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] net: adding memory barrier to the poll and receive callbacks
On Mon, 29 Jun 2009, Jarek Poplawski wrote:

> > I think Oleg already said this, but you can use directly poll_wait()
> > without adding another abstraction, and the compiler will drop the double
> > check for you:
>
> I think Oleg told about cosmetics and let Jiri to choose. I'd only
> add it's not mainly about optimization, but easy showing the main
> difference, of course depending on taste.

We already have a universally used function to do that, and that's
poll_wait().
That code (adding an extra __poll_wait()) was entirely about
optimizations (otherwise why not use the existing poll_wait()?), so if
the optimization does not actually take place, IMO it's better to not add
an extra API.



- Davide




\
 
 \ /
  Last update: 2009-06-29 19:41    [W:0.047 / U:5.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site