lkml.org 
[lkml]   [2009]   [Jun]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [KVM PATCH v5 3/4] KVM: Fix races in irqfd using new eventfd_kref_get interface
    On 06/28/2009 04:18 PM, Michael S. Tsirkin wrote:
    >
    > that could be the case, as we have, for example:
    >
    > static struct file_operations kvm_vm_fops = {
    > .release = kvm_vm_release,
    > .unlocked_ioctl = kvm_vm_ioctl,
    > .compat_ioctl = kvm_vm_ioctl,
    > .mmap = kvm_vm_mmap,
    > };
    >
    > with no owner field.
    >
    > Avi, shouldn't we initialize the owner field to prevent
    > kvm module from going away while files are open?
    >

    We do initialize it:

    kvm_chardev_ops.owner = module;
    kvm_vm_fops.owner = module;
    kvm_vcpu_fops.owner = module;

    The reason it's not done through the initializer is that we set the
    owner to the vendor module (e.g. kvm-intel.ko) so that you can't remove
    the vendor module when a guest is running.


    --
    error compiling committee.c: too many arguments to function



    \
     
     \ /
      Last update: 2009-06-28 15:27    [W:0.026 / U:0.916 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site