Messages in this thread | | | Date | Mon, 29 Jun 2009 09:03:51 +0800 | From | Xiao Guangrong <> | Subject | Re: [PATCH v2 1/2] ftrace: add tracepoint for timer |
| |
Frederic Weisbecker wrote: > On Wed, Jun 17, 2009 at 05:39:19PM +0800, Xiao Guangrong wrote: >> This patch is modify from Mathieu's patch base on Ingo's suggestion, the >> original patch can be found here: >> http://marc.info/?l=linux-kernel&m=123791201816247&w=2 >> >> Great thanks to Thomas for giving me so many valuable advices. >> >> Those tracepoints are wanted and useful: >> 1: We can detect a timer's delay >> 2: We can monitor the lifecycle and behaviors of a timer >> >> Thus they help in analysing and debuging. >> >> Example ftrace output: >> insmod-3743 [001] 217105.738770: timer_init: timer=e0b3e4c8 >> insmod-3743 [001] 217105.738868: timer_start: timer=e0b3e4c8 func=timer_fun expires=442863 timeout=50 >> <idle>-0 [001] 217105.935436: timer_expire: timer=e0b3e4c8 func=timer_fun jiffies=442863 >> <idle>-0 [001] 217105.935440: timer_cancel: timer=e0b3e4c8 func=timer_fun >> >> We expect the timer expires at 442863, after 50 jiffies, actually the timer >> expires at 442863, so it is delayed by 0 jiffies. >> >> Changelog v1->v2: >> 1: Add jiffies info into timer >> 2: Combine debugobjects and trace as Thomas's suggestion >> >> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> >> Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com> > > > Thomas, are you fine with these patches? > If so, I can prepare a pull request to Ingo, unless he prefers to > apply them himself. >
Hi Thomas,
What is your opinion on this patch? Can I get your acked-by if you think this patch is useful for us?
Thanks, Xiao
> Thanks, > Frederic. > >
| |