Messages in this thread Patch in this message | | | Date | Sun, 28 Jun 2009 12:47:16 -0400 | From | Forest Bond <> | Subject | Re: Staging: vt6656 ? |
| |
Hi,
On Sun, Jun 28, 2009 at 05:59:45PM +0200, Bartlomiej Zolnierkiewicz wrote: > On Sunday 28 June 2009 15:57:31 Forest Bond wrote: > > Hi, > > > > On Sun, Jun 28, 2009 at 03:43:12PM +0200, Bartlomiej Zolnierkiewicz wrote: > > > > > > Hi, > > > > > > On Tuesday 09 June 2009 13:33:43 Forest Bond wrote: > > > > Hi, > > > > > > > > On Tue, Jun 09, 2009 at 03:51:01AM -0700, Greg KH wrote: > > > > > On Tue, Jun 09, 2009 at 02:31:30PM +0400, Alexander Beregalov wrote: > > > > > > Hi Greg, Forest > > > > > > > > > > > > Are you going to merge driver for VT6656 also? > > > > > > > > > > If someone sends me some patches for it, sure, I will. > > > > > > > > I have patches almost ready. I'll send them by the end of next week at the > > > > latest. Busy week here. > > > > > > Did I miss the patch? There are people already doing cleanups for VT6655 > > > driver (which seems to share a great deal of code with VT6656 driver) so > > > it would greatly help to get VT6656 merged ASAP and merge the shared code > > > first to not duplicate efforts. > > > > > > Also if you need some help with integrating the driver or hosting patches > > > in git tree at kernel.org before Greg picks them up [ he seems to be buried > > > alive by patches at the moment :) ] I'll be happy to help.. > > > > I sent it to Greg about two weeks ago. I assume it is in his queue somewhere. > > There seems to be a lot of stuff in his queue.. ;) > > > Let me know if you think I ought to do something else with them. > > Please re-post with cc:ing linux-kernel so people looking for them (i.e. me) > can pick them up from the list if needed (please also cc: lkml on all patches > in the future, thanks!).
Okay. The first patch is quite large, so I will compress it.
> [ I'll later setup vt665x branch of my misc.git tree, merge your patches, > merge all outstanding vt6655 patches from Alexander and investigate a bit > more whether merge of vt665x drivers is feasible and what needs to be > done if so.. ]
Good.
FYI, there is a known issue with the drivers as I've submitted them that causes lock-ups. Please see the attached message for a suggested fix.
Thanks, Forest -- Forest Bond http://www.alittletooquiet.net http://www.pytagsfs.org From: Olivier Blin <blino@mandriva.com> To: Forest Bond <forest@alittletooquiet.net> Cc: Gábor Stefanik <netrolller.3d@gmail.com>, Greg KH <greg@kroah.com>, Larry Finger <Larry.Finger@lwfinger.net>, "John W. Linville" <linville@tuxdriver.com>, linux-wireless@vger.kernel.org, Dan Williams <dcbw@redhat.com> Bcc: Subject: Re: [PATCH] Add vt6656 driver to drivers/staging. Reply-To: In-Reply-To: <20090601165207.GA12481@alittletooquiet.net> X-Spam-Status: No, score=-4.6 required=4.8 tests=AWL,BAYES_00 autolearn=ham version=3.2.5
Forest Bond <forest@alittletooquiet.net> writes:
> Hi, > > On Mon, Jun 01, 2009 at 06:35:35PM +0200, Gábor Stefanik wrote: >> On Tue, Apr 14, 2009 at 12:52 PM, Forest Bond >> <forest@alittletooquiet.net> wrote: >> > This patch adds the vt6656 driver to drivers/staging. This code was literally >> > copied from the upstream source archive, available here: >> > >> > http://www.viaarena.com/Driver/VT6656_Linux_src_v1.19_12_x86.zip >> > >> > Copyright: VIA Networking Technologies, Inc. >> > License: GPL >> > Authors: Jerry Chen, Kyle Hsu, Lucas Lin, Lyndon Chen, Tevin Chen, Warren Hsu, >> > Yiching Chen >> > Signed-off-by: Forest Bond <forest@alittletooquiet.net> >> > >> > Patch: http://www.alittletooquiet.net/media/code/0002-Add-vt6656-driver-to-drivers-staging.patch.gz >> > Signature: http://www.alittletooquiet.net/media/code/0002-Add-vt6656-driver-to-drivers-staging.patch.gz.sig >> >> Did this patch (along with the vt6655 one) somehow get lost? I can't >> see it in drivers/staging. > > vt6655 is in drivers/staging on linux-next, although I have three more patches > that I'll be sending to Greg sometime tonight. He has been applying them for > me. > > vt6656 is currently delayed a bit. I may be able to get a start on that > tonight, as well, but there is likelihood of further delay.
By the way, are you sure about the hook below about wpactl.c in commit 8f2c32b86b3ac16ba4c93bf0c2b766089644d9d1 ?
If I do the same in vt6656, it is freezing the kernel, or causing random crashes. Removing the netdev priv assignation makes the driver ok. I don't think the wpa priv was really useful, but I fail to see where it was used, and why it caused the hang.
Don't you have the same issue with vt6655?
BTW, I have some patches to send for vt6656, what is the proper place to submit them since vt6656 is not in staging for now?
diff --git a/drivers/staging/vt6655/wpactl.c b/drivers/staging/vt6655/wpactl.c index ee7109d..cc4f0ad 100644 (file) --- a/drivers/staging/vt6655/wpactl.c +++ b/drivers/staging/vt6655/wpactl.c @@ -112,14 +112,17 @@ static void wpadev_setup(struct net_device *dev) static int wpa_init_wpadev(PSDevice pDevice) { + PSDevice wpadev_priv; struct net_device *dev = pDevice->dev; int ret=0; - pDevice->wpadev = alloc_netdev(0, "vntwpa", wpadev_setup); + pDevice->wpadev = alloc_netdev(sizeof(PSDevice), "vntwpa", wpadev_setup); if (pDevice->wpadev == NULL) return -ENOMEM; - pDevice->wpadev->priv = pDevice; + wpadev_priv = netdev_priv(pDevice->wpadev); + *wpadev_priv = *pDevice; + memcpy(pDevice->wpadev->dev_addr, dev->dev_addr, U_ETHER_ADDR_LEN); pDevice->wpadev->base_addr = dev->base_addr; pDevice->wpadev->irq = dev->irq; -- Olivier Blin (blino) - Mandriva
[unhandled content-type:application/pgp-signature] | |