Messages in this thread | | | Subject | Re: [PATCH] SCSI: userspace cannot use scsi_command_size_tbl, COMMAND_SIZE and scsi_device_type | From | James Bottomley <> | Date | Sun, 28 Jun 2009 09:44:42 -0500 |
| |
On Sun, 2009-06-28 at 10:32 -0400, James Smart wrote: > Sorry folks -- the nuance of the clibrary having it's own version of a > kernel header for distros was completely unknown to me. > > Christoph mentioned this to me last week, with the recommendation to > back out the patch and move the other headers that were exprted into > include/linux - thus nothing in include/scsi gets export. No Problem. > and I'll do so shortly.
Actually, I'm not sure that's the best way forwards ... the idea of include/scsi is to group all the SCSI headers together; having to put them in include/linux if they need to be exported defeats that purpose slightly.
I think the first point of business might be to find out why (or even if) glibc still wants its own SCSI headers. After all, we now have quite an anomaly: if you use the old SG_IO ioctl, glibc supplies the header in include/scsi/sg.h; if you use the new bsg SG_IO then we supply it in include/linux/bsg.h
> How does a lowly contributor track these kind of nuances ?
If the creator of the kernel header exports missed this problem for a year, I think it's safe to assume you don't lose brownie points for not spotting it either.
James
| |