Messages in this thread | | | Date | Sun, 28 Jun 2009 00:06:24 +0900 (JST) | Subject | Re: [PATCH 1/2 v2] dmaengine: at_hdmac: new driver for the Atmel AHB DMA Controller | From | Atsushi Nemoto <> |
| |
On Fri, 26 Jun 2009 12:42:15 +0200, Nicolas Ferre <nicolas.ferre@atmel.com> wrote: > This AHB DMA Controller (aka HDMA or DMAC on AT91 systems) is availlable on > at91sam9rl chip. It will be used on other products in the future.
It seems this driver was written based on dw_dmac driver. A while ago I had some investigation of that driver. (http://lkml.org/lkml/2008/12/29/172)
Some of issues reported at that time could be applied on your driver too. With a quick look, the queue list management issue is a candidate. Here is an excerpt from the thread:
--- --- --- 3. dwc->queue list management
The function dwc_tx_submit() add the descriptor to dwc->queue list if active list was not empty. But it does not manage lli.llp list. And all descriptors in the queue list will be moved to active list at a time. So it seems non-first descriptors in queue list will never processed by the hardware.
The dwc_tx_submit() should rewrite lli.llp of the last descriptor in queue list (it it had children, the last children of it) by txd.phys of newly queued descriptor. Or, only first elements of queue list should be moved to active list at a time.
Is my analysis correct? --- --- ---
And one more comment.
> + /* > + * We use dma_unmap_page() regardless of how the buffers were > + * mapped before they were submitted... > + */
You can use DMA_COMPL_{SRC,DEST}_UNMAP_SINGLE since 2.6.30.
--- Atsushi Nemoto
| |