lkml.org 
[lkml]   [2009]   [Jun]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] virtio_blk: add missing __dev{init,exit} markings
On Wed, 20 May 2009 00:10:51 +0930
Rusty Russell <rusty@rustcorp.com.au> wrote:

> On Mon, 18 May 2009 05:09:09 pm Mike Frysinger wrote:
> > -static int virtblk_probe(struct virtio_device *vdev)
> > +static int __devinit virtblk_probe(struct virtio_device *vdev)
>
> This makes sense, I think, but then it implies that
> virtio_dev_probe() should also be __devinit, right?
>
> And I look at pci_bus_probe(), and it's not __devinit.
>
> Is the PCI code just slack?

I wouldn't be surprised if some annotations were missing or incorrect
given the churn in hotplug lately, but I can't find that particular
symbol...

--
Jesse Barnes, Intel Open Source Technology Center


\
 
 \ /
  Last update: 2009-06-26 21:41    [W:0.038 / U:0.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site