lkml.org 
[lkml]   [2009]   [Jun]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] IDE: ide-taskfile.c fix compilation warning and cleanup
Date
On Friday 26 June 2009 05:18:10 Jaswinder Singh Rajput wrote:
> On Mon, 2009-06-22 at 12:50 +0200, Bartlomiej Zolnierkiewicz wrote:

> > Besides I would suggest splitting the patch on fix and cleanup parts.
>
> Here is the cleanup part:
>
> [PATCH] IDE: ide-taskfile.c fix style problems
>
> Fix trivial style problems:
>
> WARNING: Use #include <linux/uaccess.h> instead of <asm/uaccess.h>
> WARNING: space prohibited between function name and open parenthesis '('
> WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> ERROR: do not use C99 // comments X 2
> ERROR: trailing statements should be on next line
> ERROR: trailing whitespace
> ERROR: switch and case should be at the same indent
> WARNING: line over 80 characters
>
> total: 5 errors, 4 warnings
>
> Also removed dead code
>
> Also used pr_err() to avoid line breaks
>
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>

Acked-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>


\
 
 \ /
  Last update: 2009-06-26 21:39    [W:0.064 / U:0.760 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site