lkml.org 
[lkml]   [2009]   [Jun]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/9] x86/moorestown: add moorestown platform flags
    On Fri, 26 Jun 2009 09:19:55 +0200
    Ingo Molnar <mingo@elte.hu> wrote:
    > > void platform_feature_init_default(int subarch_id)
    > > {
    > > - printk(KERN_INFO "Use default X86 platform feature set\n");
    > > + if ((subarch_id >= 0) && (subarch_id < N_X86_SUBARCHS)) {
    > > + if (subarch_id == X86_SUBARCH_MRST) {
    > > + setup_mrst_default_feature();
    > > + return;
    > > + }
    > > + } else {
    > > + printk(KERN_INFO "Use default X86 platform feature
    > > set\n");
    > > + }
    > > }
    >
    > Why dont we have some clean and robust PCI config space based
    > enumeration instead of this boot ID based thing?

    MRST has special PCI support that depends on having the platform
    identified already, so if you want to use something other than a flag
    here, maybe we could use an SFI string instead.

    --
    Jesse Barnes, Intel Open Source Technology Center


    \
     
     \ /
      Last update: 2009-06-26 18:53    [W:0.020 / U:1.288 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site