Messages in this thread | | | Subject | Re: kmemleak suggestion (long message) | From | Catalin Marinas <> | Date | Fri, 26 Jun 2009 17:12:46 +0100 |
| |
On Fri, 2009-06-26 at 11:50 +0300, Sergey Senozhatsky wrote: > On (06/26/09 11:17), Pekka Enberg wrote: > > Well, the thing is, I am not sure it's needed if we implement Ingo's > > suggestion. After all, syslog is no longer spammed very hard and you can > > do all the filtering in userspace when you read /debug/mm/kmemleak file, > > no? > > Well, we just move 'spam' out of syslog. Not dealing with 'spam' itself. > I'm not sure about 'filtering in userspace when you read'. Suppose I use > 'tail -f /debug/mm/kmemleak'. How can I easy suppress printing of (for example):
I had a look at your patch and I tend to agree with Pekka. It really adds too much complexity for something that could be easily done in user space (could be more concise or even written in perl, awk, sed, python etc.):
cat /sys/kernel/debug/kmemleak | tr "\n" "#" \ | sed -e "s/#unreferenced/\nunreferenced/g" \ | grep -v "tty_ldisc_try_get" | tr "#" "\n"
It would have made sense with the output in syslog but I just removed this feature.
As for "tail -f", I'm not sure it would work anyway because of the way the seqfile content is generated. New detected leaks aren't necessarily appended to the kmemleak file. They are always listed in the order they were allocated.
Thanks anyway.
-- Catalin
| |