lkml.org 
[lkml]   [2009]   [Jun]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRE: [PATCH 9/9] x86/apic: support moorestown interrupt subsystem
    >
    >This code is stylistically and structurally challenged and will need
    >a lot more work to be acceptable. Please clean it up and abstract
    >out the timer driver bits:
    >
    >The proper solution here is to first introduce a proper abstraction
    >without adding the ABP bits - then can come a separate ABP patch
    >that adds the new hardware support - without touching any other code
    >but adding its own small driver module.
    >
    > Ingo
    [[JPAN]] thanks for the detailed comments, I will fix the style problem in the
    next version. I can separate APB timer code into another patch. But I need
    a little more clarification for the abstraction you want. The reason why I did
    it this way was it is similar to the other arch_setup_xx, e.g. HPET. In
    io_apic.c
    So do you want to abstract all the arch_setup_xxx in the new abstraction layer?


    \
     
     \ /
      Last update: 2009-06-26 15:51    [W:3.183 / U:0.248 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site