Messages in this thread | | | From | "Pan, Jacob jun" <> | Date | Fri, 26 Jun 2009 06:48:57 -0700 | Subject | RE: [PATCH 9/9] x86/apic: support moorestown interrupt subsystem |
| |
> >This code is stylistically and structurally challenged and will need >a lot more work to be acceptable. Please clean it up and abstract >out the timer driver bits: > >The proper solution here is to first introduce a proper abstraction >without adding the ABP bits - then can come a separate ABP patch >that adds the new hardware support - without touching any other code >but adding its own small driver module. > > Ingo [[JPAN]] thanks for the detailed comments, I will fix the style problem in the next version. I can separate APB timer code into another patch. But I need a little more clarification for the abstraction you want. The reason why I did it this way was it is similar to the other arch_setup_xx, e.g. HPET. In io_apic.c So do you want to abstract all the arch_setup_xxx in the new abstraction layer?
| |