Messages in this thread | | | From | Florian Fainelli <> | Subject | Re: [PATCH 1/1] Minor code cleanup in drivers/net/r6040.c | Date | Thu, 25 Jun 2009 10:18:40 +0200 |
| |
Le Thursday 25 June 2009 09:05:09 Michael Opdenacker, vous avez écrit : > Replaced '0' by 'bar' in the probe function. > The 'bar' variable was already set to '0' and is already > used in pci_iomap(). This is cleaner and improves code > consistency. > > Signed-off-by: Michael Opdenacker <michael@free-electrons.com>
Acked-by: Florian Fainelli <florian@openwrt.org>
> --- > drivers/net/r6040.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/r6040.c b/drivers/net/r6040.c > index ed63d23..b3197e9 100644 > --- a/drivers/net/r6040.c > +++ b/drivers/net/r6040.c > @@ -1112,13 +1112,13 @@ static int __devinit r6040_init_one(struct pci_dev > *pdev, } > > /* IO Size check */ > - if (pci_resource_len(pdev, 0) < io_size) { > + if (pci_resource_len(pdev, bar) < io_size) { > printk(KERN_ERR DRV_NAME ": Insufficient PCI resources, aborting\n"); > err = -EIO; > goto err_out; > } > > - pioaddr = pci_resource_start(pdev, 0); /* IO map base address */ > + pioaddr = pci_resource_start(pdev, bar); /* IO map base address */ > pci_set_master(pdev); > > dev = alloc_etherdev(sizeof(struct r6040_private));
-- Best regards, Florian Fainelli Email : florian@openwrt.org http://openwrt.org ------------------------------- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |