Messages in this thread | | | Date | Thu, 25 Jun 2009 06:38:18 +0200 | From | Nick Piggin <> | Subject | Re: [PATCH v2] slab,slub: ignore __GFP_WAIT if we're booting or suspending |
| |
On Fri, Jun 12, 2009 at 07:59:34PM +1000, Benjamin Herrenschmidt wrote: > > > Maybe if we just not make it a general "tweak gfpflag" bit (at > > least not until a bit more discussion), but a specific workaround > > for the local_irq_enable in early boot problem. > > > > Seems like it would not be hard to track things down if we add > > a warning if we have GFP_WAIT and interrupts are not enabled... > > But tweaking local_irq_enable() will have a lot more performance & bloat > impact overall on the normal case.
(sorry for the late replies. I've been sick and missed a few things over the past week or two... not that this is a really urgent issue ;))
I was not proposing to put a branch in local_irq_enable ;) but to use local_irq_save/restore in the slab allocators rather than unconditional.
| |