lkml.org 
[lkml]   [2009]   [Jun]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] perf stat: fix hardcoded nr_counter

* Jaswinder Singh Rajput <jaswinder@kernel.org> wrote:

> nr_counter should be based on number of default_attrs entries.

The problem is, this will cause a _lot_ of counters to be used by
default, overloading the PMU quite significantly and reducing
precision. The number of hw counters is chosen intentionally the way
it is now, so that on common hardware there's no over-commit.

As i suggested before, your change does make sense if introduced as
extended event specifications to 'perf stat':

-e all
-e all-sw-counters
-e all-hw-counters

with regex wildcard support too.

Instead, you chose to ignore my feedback and wasted my time by
re-sending the same broken patch. If you do such things i'll have to
start ignoring you - it is very ineffective for me to repeat every
argument and suggestion two or more times and no other contributor
does this ...

> Remove dead code and some code alignment.

Could you please send this separately?

Ingo


\
 
 \ /
  Last update: 2009-06-24 11:01    [W:0.103 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site