Messages in this thread | | | Subject | Re: [PATCH] pata_rdc: driver for RDC ATA devices | From | Joe Perches <> | Date | Wed, 24 Jun 2009 16:33:45 -0700 |
| |
On Wed, 2009-06-24 at 23:55 +0100, Alan Cox wrote: > > Seems fine and fairly straightforward to me. My lone comment -- go > > through and replace magic numbers with named constants, for e.g. the PCI > > config registers that program timings... > > Its based on your ata_piix driver. Feel free to update that and I'll pull > names and things across to match.
I sent a few patches to Jeff privately to do just that.
I'm waiting for Jeff to see if he wants me to post them publicly or not.
btw:
Jeff, your email address in MAINTAINERS is jgarzik@pobox.com. Should it be changed to redhat.com or garzik.org or left as is.
$ git log --since=1-year-ago | grep -i "by:.*garzik" | \ cut -f2- -d":" | sort | uniq -c | sort -rn 865 Jeff Garzik <jgarzik@redhat.com> 13 Jeff Garzik <jgarzik@pobox.com> 13 Jeff Garzik <jeff@garzik.org>
| |