Messages in this thread | | | Date | Tue, 23 Jun 2009 23:58:38 -0700 (PDT) | Subject | Re: [PATCH v2] ftrace: change the export format of trace_kfree_skb() | From | David Miller <> |
| |
FWIW there are parts I don't like about this change.
It's just the show_protocol_name() bit, it's designed to always be out of date.
Nobody is going to look at trace/events/skb.h when they add a new ETH_P_* value.
We could make some include/linux/eth_protos.def file, that has lines like:
ETHERNET_PROTOCOL(ETH_P_FOO, N)
then headers that want to instantiate something like the usual ETH_P_FOO defines or this symbolic printing table define "ETHERNET_PROTOCOL" to a suitable macro and then include linux/eth_protos.def to make the expansions.
| |