Messages in this thread | | | Date | Wed, 24 Jun 2009 03:39:09 -0700 (PDT) | Subject | Re: [patch 2/6] ide: fix ide_kill_rq() for special ide-{floppy,tape} driver requests | From | David Miller <> |
| |
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> Date: Wed, 24 Jun 2009 12:09:53 +0200
> The obscure reasons is just the fact that both ide-floppy and ide-tape > had a they own duplicated/buggy request completion routines. > > While they were being unified the whole bunch of similar class of bugs > were fixed so I agree that there may still be more issues to deal with > there.
I see, the ->pc_callback() of these things set rq->errors and then ide_pc_intr() happily overrides whatever was set there, either on it's own or via ide_complete_rq().
I'll look over this some more while I wait for the testing results from Borislav.
| |