lkml.org 
[lkml]   [2009]   [Jun]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [RFC,PATCH 2/2] change __wake_up_parent() to use filtered wakeup
Date
Looks good, I'm glad to see this revived.  

I note that even simpler than eligible_child() is just:

if ((wo->wo_flags & __WNOTHREAD) && wo->child_wait.private != p->parent)
return 0;

IIRC that is the test that Ratan's original patch used to address the
particular application usage that first troubled him. But probably this
is already what you meant by "more clever later" (and ->parent is perhaps
not right in all cases there).

Your two patches as they are look safe and useful to me and I hope they can
go in soon.


Thanks,
Roland


\
 
 \ /
  Last update: 2009-06-24 11:51    [W:0.105 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site