lkml.org 
[lkml]   [2009]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/4] asm/sections: add text/data checking functions for arches to override
On Tue, 23 Jun 2009 21:48:03 -0400 Mike Frysinger <vapier.adi@gmail.com> wrote:

> > I suppose that for completeness and consistency etc really we should have
> >
> > #define arch_is_kernel_text arch_is_kernel_text
> > #define arch_is_kernel_data arch_is_kernel_data
> >
> > in here.
>
> *shrug* other places that use this style dont include these defines
> for completeness

Examples?

All the ones I can find do things like

#ifndef vmcore_elf_check_arch_cross
#define vmcore_elf_check_arch_cross(x) 0
#endif

> as the define muck is for the header to know about
> (arches providing their own version), not any source code -- they
> shouldnt know anything about the ifdef stuff.

Failing to do the #define will have various tricky failure modes. But
it's more a question of "what is the _right_ thing to do", then doing
that consistently.

> i dont care much either way.

Someone has to.


\
 
 \ /
  Last update: 2009-06-24 04:11    [W:0.029 / U:26.764 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site