lkml.org 
[lkml]   [2009]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [patch 3/6] ide: always kill the whole request on error
    From
    From: Joe Perches <joe@perches.com>
    Date: Tue, 23 Jun 2009 16:37:54 -0700

    > On Tue, 2009-06-23 at 16:19 -0700, David Miller wrote:
    >> From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
    >> Date: Tue, 23 Jun 2009 23:27:27 +0200
    >> > From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
    >> > Subject: [PATCH] ide: always kill the whole request on error
    >> > --- a/drivers/ide/ide-eh.c
    >> > +++ b/drivers/ide/ide-eh.c
    >> > @@ -149,7 +149,7 @@ static inline void ide_complete_drive_re
    >> > if (rq && blk_special_request(rq) && rq->cmd[0] == REQ_DRIVE_RESET) {
    >> > if (err <= 0 && rq->errors == 0)
    >> > rq->errors = -EIO;
    >> > - ide_complete_rq(drive, err ? err : 0, ide_rq_bytes(rq));
    >> > + ide_complete_rq(drive, err ? err : 0, blk_rq_bytes(rq));
    >
    > Doesn't that "err ? err : 0" look odd?
    > Why not just err?

    These functions are full of surprises :-)

    Yes, plain 'err' should be absolutely equivalent to what's
    there right now.


    \
     
     \ /
      Last update: 2009-06-24 01:41    [W:0.019 / U:119.608 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site