lkml.org 
[lkml]   [2009]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] mm/init: cpu_hotplug_init() must be initialized before SLAB
From
Date
On Tue, 23 Jun 2009, Benjamin Herrenschmidt wrote:
> > + /*
> > + * This initializes the mutex used by get/put_online_cpus()
> > + * which is used by SLAB
> > + */
> > + cpu_hotplug_init();

On Mon, 2009-06-22 at 19:29 -0700, Linus Torvalds wrote:
> Oh fudge it.
>
> Why not get rid of that stupid thing, rather than have that subtle
> dependency and a comment for it.
>
> IOW, does this simpler alternative also work?
>
> When given the choice of simplifying and removing code, always do so.
>
> Static initializers are much nicer than having to worry about when
> something gets initialized, no?

Looks good to me. Thanks for fixing it up, Linus!

Pekka



\
 
 \ /
  Last update: 2009-06-23 08:01    [W:0.045 / U:8.808 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site