[lkml]   [2009]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 3/5] power_supply: add a TRICKLE_CHARGING status, and add it to the olpc driver
    On Mon, Jun 22, 2009 at 11:46:07PM -0400, Andres Salomon wrote:

    > The hardware has an extra bit that specifies that the battery is trickle
    > charging, so when determining if the battery is present/charging the TRICKLE
    > bit needs to be checked as well. Because battery diagnostics might want to
    > know whether trickle charging is happening or not, and also because trickle
    > charging falls somewhere between charging and not charging (read: Richard got
    > mad at me when I tried to set CHARGING when in trickle charge. He gets so
    > angry sometimes), we add a new TRICKLE status to sysfs.

    To avoid confusing usere applications might it be better to add another
    piece of information with detail on the charger status rather than a new
    state? The fact that the new state name shares a prefix with the
    regular charging state does help here but you might still confuse things
    and it makes the name of the new state in sysfs a bit awkward.

    I'd also be tempted to do this the other way around and add a fast
    charge status; certainly in embedded cases trickle charging is more of a
    default state since it requires less incoming power (important if you're
    using USB) and there's less risk of damage to the battery.

     \ /
      Last update: 2009-06-23 12:39    [W:0.020 / U:31.456 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site