lkml.org 
[lkml]   [2009]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] cs5520: add missing IRQ setup for the second port
    Date
    On Tuesday 23 June 2009 10:42:06 Alan Cox wrote:
    > On Tue, 23 Jun 2009 01:58:11 +0200
    > Frans Pop <elendil@planet.nl> wrote:
    >
    > > David Miller wrote:
    > > > ide_pci_setup_ports() would loop over the available ports, one
    > > > by one, recording IRQ numbers increasingly from the one passed
    > > > in as "pciirq".
    > >
    > > I looked at the commit and at the code and called functions several times
    > > (just out of curiosity), but have been completely unable to find where
    > > that increase of pciirq actually happened.
    > > AFAICT ide_pci_setup_ports() just passed it on to ide_hw_configure() and
    > > all that did was 'hw->irq = irq', so AFAICT in the old case both ports
    > > would get the *same* IRQ, and not consecutive ones.
    >
    > The cs5520 isn't a standard IDE controller in the first place and doesn't
    > have two channels anyway. It's special as it uses non standard bar

    Please note that both cs5520.c / pata_cs5520.c assume that the controller
    has two ports (please verify whether they need some fixing, thanks)..


    \
     
     \ /
      Last update: 2009-06-23 11:55    [W:0.021 / U:88.772 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site