Messages in this thread |  | | Date | Tue, 23 Jun 2009 11:03:47 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH 3/8] SFI: core support |
| |
* Feng Tang <feng.tang@intel.com> wrote:
> On Tue, 23 Jun 2009 15:56:43 +0800 > Ingo Molnar <mingo@elte.hu> wrote: > > > > > > > > +#ifdef CONFIG_X86_LOCAL_APIC > > > +static u64 sfi_lapic_addr __initdata = APIC_DEFAULT_PHYS_BASE; > > > +#endif > > > > if SFI adds a 'depends on X86_LOCAL_APIC' the ugly #ifdef can be > > dropped. > > When Len designed the SFI spec, he considered the possibility of > being used by multiple archs, so we chose not to add a x86 > dependency, though adding these > #ifdef does make code ugly :P
But the file i commented on is arch/x86/kernel/sfi.c, not drivers/sfi/.
Those #ifdefs arent _that_ bad (and are used elsewhere in x86 code too) - but generally some effort should be spent in new code on trying to eliminate them.
> > In general, nice stuff - basically SFI is cleanly implemented > > ACPI tables without any of the run-code-in-acpi-tables > > complications, right? > > Thanks for the comments, I really got inspired :). The expectation > for SFI is to be able to run cleanly with CONFIG_ACPI=n, and it > works fine on some intel platform.
Ok, cool!
Ingo
|  |