lkml.org 
[lkml]   [2009]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] ide-cd: Improve "weird block size" error message
Date
On Tuesday 23 June 2009, Borislav Petkov wrote:
> > diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c
> > index 4a19686..7ec6996 100644
> > --- a/drivers/ide/ide-cd.c
> > +++ b/drivers/ide/ide-cd.c
> > @@ -886,10 +886,9 @@ static int cdrom_read_capacity(ide_drive_t
> > *drive, unsigned long *capacity, case 4096:
> > break;
> > default:
> > - printk(KERN_ERR PFX "%s: weird block size %u\n",
> > + printk_once(KERN_ERR PFX "%s: weird block size %u; "
^^^^^^^
> > + "setting default block size to 2048\n",
> > drive->name, blocklen);
> > - printk(KERN_ERR PFX "%s: default to 2kb block size\n",
> > - drive->name);

> Please leave the weird block size in the printk since it sometimes
> might give insights on what is going on.

I did :-)


\
 
 \ /
  Last update: 2009-06-23 10:23    [from the cache]
©2003-2011 Jasper Spaans