lkml.org 
[lkml]   [2009]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ide-cd: Improve "weird block size" error message
On Tue, Jun 23, 2009 at 09:51:23AM +0200, Frans Pop wrote:

[..]

> ---
> From: Frans Pop <elendil@planet.nl>
> Subject: ide-cd: Improve "weird block size" error message
>
> Currently the error gets repeated too frequently, for example
> each time HAL polls the device when a disc is present. Avoid that
> by using printk_once instead of printk.
> Also join the error and corrective action messages into a single line.
>
> Signed-off-by: Frans Pop <elendil@planet.nl>
> Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
>
> diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c
> index 4a19686..7ec6996 100644
> --- a/drivers/ide/ide-cd.c
> +++ b/drivers/ide/ide-cd.c
> @@ -886,10 +886,9 @@ static int cdrom_read_capacity(ide_drive_t *drive, unsigned long *capacity,
> case 4096:
> break;
> default:
> - printk(KERN_ERR PFX "%s: weird block size %u\n",
> + printk_once(KERN_ERR PFX "%s: weird block size %u; "
> + "setting default block size to 2048\n",
> drive->name, blocklen);
> - printk(KERN_ERR PFX "%s: default to 2kb block size\n",
> - drive->name);

Please leave the weird block size in the printk since it sometimes might
give insights on what is going on.

Thanks.

--
Regards/Gruss,
Boris.


\
 
 \ /
  Last update: 2009-06-23 10:01    [W:0.102 / U:4.500 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site