lkml.org 
[lkml]   [2009]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] net-dccp: Suppress warning about large allocations from DCCP
Em Mon, Jun 22, 2009 at 04:15:02PM -0700, David Miller escreveu:
> From: Mel Gorman <mel@csn.ul.ie>
> Date: Mon, 22 Jun 2009 16:43:34 +0100
>
> > The DCCP protocol tries to allocate some large hash tables during
> > initialisation using the largest size possible. This can be larger than
> > what the page allocator can provide so it prints a warning. However, the
> > caller is able to handle the situation so this patch suppresses the warning.
> >
> > Signed-off-by: Mel Gorman <mel@csn.ul.ie>
>
> It's probably much more appropriate to make this stuff use
> alloc_large_system_hash(), like TCP does (see net/ipv4/tcp.c
> tcp_init()).
>
> All of this complicated DCCP hash table size computation code will
> simply disappear. And it'll fix the warning too :-)

He mentioned that in the conversation that lead to this new patch
series, problem is that alloc_large_system_hash is __init, so when you
try to load dccp.ko it will not be available.

- Arnaldo


\
 
 \ /
  Last update: 2009-06-23 04:43    [from the cache]
©2003-2011 Jasper Spaans