lkml.org 
[lkml]   [2009]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: Badness on the Warp
    From
    Hi Sean,

    On Mon, Jun 22, 2009 at 1:36 AM, Sean MacLennan<smaclennan@pikatech.com> wrote:
    > On Mon, 22 Jun 2009 08:25:04 +1000
    > Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
    >
    >> Right, our interrupt controllers need those fixes, they are low
    >> on my priority list since it's a reasonably harmless warning and I'm
    >> still chasing some actual breakage (though maybe not directly related
    >> to your patches).
    >>
    >> Kumar already submitted a couple, Frans, feel free to beat me
    >> at converting UIC (just use kmalloc directly in there instead
    >> of alloc_bootmem).
    >
    > I can make the changes to UIC if you want. They badness is harmless (it
    > ends up calling kzalloc anyway), but hard to explain to our PV (Product
    > Verification) department that they can ignore what looks like a crash ;)

    Right. We can also wrap the WARN_ON() in CONFIG_DEBUG_BOOTMEM or
    something too but I'd prefer a proper fix here.

    Pekka


    \
     
     \ /
      Last update: 2009-06-22 06:51    [W:0.020 / U:0.452 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site