lkml.org 
[lkml]   [2009]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 07/15] vt_ioctl: fix lock imbalance
    Date
    From: Jiri Slaby <jirislaby@gmail.com>

    Don't return from switch/case directly in vt_ioctl. Set ret and break
    instead so that we unlock BKL.

    Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
    Signed-off-by: Alan Cox <alan@linux.intel.com>
    Cc: stable@kernel.org
    ---

    drivers/char/vt_ioctl.c | 3 ++-
    1 files changed, 2 insertions(+), 1 deletions(-)


    diff --git a/drivers/char/vt_ioctl.c b/drivers/char/vt_ioctl.c
    index e6ce632..7539bed 100644
    --- a/drivers/char/vt_ioctl.c
    +++ b/drivers/char/vt_ioctl.c
    @@ -396,7 +396,8 @@ int vt_ioctl(struct tty_struct *tty, struct file * file,
    kbd = kbd_table + console;
    switch (cmd) {
    case TIOCLINUX:
    - return tioclinux(tty, arg);
    + ret = tioclinux(tty, arg);
    + break;
    case KIOCSOUND:
    if (!perm)
    goto eperm;


    \
     
     \ /
      Last update: 2009-06-22 18:47    [W:0.040 / U:63.412 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site