lkml.org 
[lkml]   [2009]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] PCI: remove pcibios_scan_all_fns()
    On Mon, Jun 22, 2009 at 08:08:07AM -0600, Alex Chiang wrote:
    > This was #define'd as 0 on all platforms, so let's get rid of it.
    >
    > This change makes pci_scan_slot() slightly easier to read.

    > diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
    > index f1ae247..b613cad 100644
    > --- a/drivers/pci/probe.c
    > +++ b/drivers/pci/probe.c
    > @@ -1056,8 +1056,7 @@ int pci_scan_slot(struct pci_bus *bus, int devfn)
    > if (dev && !dev->is_added) /* new device? */
    > nr++;
    >
    > - if ((dev && dev->multifunction) ||
    > - (!dev && pcibios_scan_all_fns(bus, devfn))) {
    > + if (dev && dev->multifunction) {
    > for (fn = 1; fn < 8; fn++) {
    > dev = pci_scan_single_device(bus, devfn + fn);
    > if (dev) {

    What a good idea. I was just looking at making this more complicated
    (due to the ARI capability).

    I'd like to know what the KVM / Xen / ... people think about this.
    I don't know if they rely on function 5 being able to show up out of
    the blue.

    Anyway,
    Reviewed-by: Matthew Wilcox <willy@linux.intel.com>

    --
    Matthew Wilcox Intel Open Source Technology Centre
    "Bill, look, we understand that you're interested in selling us this
    operating system, but compare it to ours. We can't possibly take such
    a retrograde step."


    \
     
     \ /
      Last update: 2009-06-22 16:37    [W:0.021 / U:0.440 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site