lkml.org 
[lkml]   [2009]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] IDE: ide-taskfile.c fix compilation warning and cleanup
Date
On Monday 22 June 2009 08:09:33 Jaswinder Singh Rajput wrote:

> @@ -248,8 +250,9 @@ void ide_pio_bytes(ide_drive_t *drive, struct ide_cmd *cmd,
> page = nth_page(page, (offset >> PAGE_SHIFT));
> offset %= PAGE_SIZE;
>
> - if (PageHighMem(page))
> - local_irq_save(flags);
> +#ifdef CONFIG_HIGHMEM
> + local_irq_save(flags);
> +#endif
>
> buf = kmap_atomic(page, KM_BIO_SRC_IRQ) + offset;
>
> @@ -269,8 +272,9 @@ void ide_pio_bytes(ide_drive_t *drive, struct ide_cmd *cmd,
>
> kunmap_atomic(buf, KM_BIO_SRC_IRQ);
>
> - if (PageHighMem(page))
> - local_irq_restore(flags);
> +#ifdef CONFIG_HIGHMEM
> + local_irq_restore(flags);
> +#endif

This part is incorrect (adds a performance regression for low-mem pages
w/ HIGHMEM=y) and seems to be accidental (nothing about it in the patch
description).

Besides I would suggest splitting the patch on fix and cleanup parts.


\
 
 \ /
  Last update: 2009-06-22 13:47    [W:0.111 / U:0.976 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site