lkml.org 
[lkml]   [2009]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [POWERNOW PATCH] x86: powernow-k8 move power management MSRs declaration to msr-index.h
On Sat, Jun 20, 2009 at 03:56:21PM +0530, Jaswinder Singh Rajput wrote:
>
> Keep all MSRs declaration in msr-index.h to easily access MSRs declaration.
>
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>

The objection I have to this, is that there's no other use for these MSRs
outside of a powernow driver. They aren't "power management MSRs"
they're "powernow MSRs".

IMO msr-index should be used for MSRs that may be used by multiple files,
reducing duplication. Here we're just moving something around for
no obvious benefit.

Dave



\
 
 \ /
  Last update: 2009-06-20 16:57    [W:0.202 / U:0.732 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site