Messages in this thread | | | Date | Sat, 20 Jun 2009 10:45:39 -0400 | From | Dave Jones <> | Subject | Re: [POWERNOW PATCH] x86: powernow-k8 move power management MSRs declaration to msr-index.h |
| |
On Sat, Jun 20, 2009 at 03:56:21PM +0530, Jaswinder Singh Rajput wrote: > > Keep all MSRs declaration in msr-index.h to easily access MSRs declaration. > > Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
The objection I have to this, is that there's no other use for these MSRs outside of a powernow driver. They aren't "power management MSRs" they're "powernow MSRs".
IMO msr-index should be used for MSRs that may be used by multiple files, reducing duplication. Here we're just moving something around for no obvious benefit.
Dave
| |