Messages in this thread | | | Date | Sat, 20 Jun 2009 01:21:07 -0700 (PDT) | Subject | Re: [PATCH 1/1] Net: qla3xxx, remove sleeping in atomic | From | David Miller <> |
| |
From: Jiri Slaby <jirislaby@gmail.com> Date: Fri, 19 Jun 2009 17:13:32 +0200
> Hi, we've found this sleep-inside-spinlock. > > The fix below totally untested, please review carefully. > > -- > > We cannot sleep in ql_reset_work under spinlock, unlock before sleep, > relock after. > > Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
This looks good. The spinlock is just required to be held around the register accesses. It's going to drop the lock as soon as the bits settle post-reset anyways and then the driver goes off and modifies other state outside of the lock.
Applied, thanks!
| |