lkml.org 
[lkml]   [2009]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/1] Net: qla3xxx, remove sleeping in atomic
From
From: Jiri Slaby <jirislaby@gmail.com>
Date: Fri, 19 Jun 2009 17:13:32 +0200

> Hi, we've found this sleep-inside-spinlock.
>
> The fix below totally untested, please review carefully.
>
> --
>
> We cannot sleep in ql_reset_work under spinlock, unlock before sleep,
> relock after.
>
> Signed-off-by: Jiri Slaby <jirislaby@gmail.com>

This looks good. The spinlock is just required to be held
around the register accesses. It's going to drop the lock
as soon as the bits settle post-reset anyways and then the
driver goes off and modifies other state outside of the lock.

Applied, thanks!


\
 
 \ /
  Last update: 2009-06-20 10:25    [W:0.063 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site