Messages in this thread | | | Date | Tue, 2 Jun 2009 16:23:10 -0700 | From | Greg KH <> | Subject | Re: [PATCH] debugfs: use specified mode to possibly mark files read/write only |
| |
On Tue, Jun 02, 2009 at 03:00:47AM -0400, Mike Frysinger wrote: > From: Robin Getz <rgetz@blackfin.uclinux.org> > > In many SoC implementations there are hardware registers can be read or > write only. This extends the debugfs to enforce the file permissions for > these types of registers by providing a set of fops which are read or > write only. This assumes that the kernel developer knows more about the > hardware than the user (even root users) -- which is normally true. > > Signed-off-by: Robin Getz <rgetz@blackfin.uclinux.org> > Signed-off-by: Mike Frysinger <vapier@gentoo.org> > Signed-off-by: Bryan Wu <cooloney@kernel.org> > --- > you mention debugfs header file changes, but i don't see what would need > changing ? the mode checking is all done internally ...
Looks good to me.
| |