lkml.org 
[lkml]   [2009]   [Jun]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 1/3] x86: provide CPU topology information for multi-node processors
    From
    On Tue, Jun 2, 2009 at 17:58, Andreas Herrmann
    <andreas.herrmann3@amd.com> wrote:
    > On Tue, Jun 02, 2009 at 05:05:07PM +0200, Bert Wesarg wrote:
    >> On Fri, May 29, 2009 at 20:42, Andreas Herrmann
    >> <andreas.herrmann3@amd.com> wrote:
    >> > This support can be switched off/on using a new config option
    >> > MULTI_NODE_CPU. If the option is set the CPU topology information is
    >> > extended with cpu_node information. This includes a cpu_node_id,
    >> > cpu_node_siblings and cpu_node_siblings_list.
    >
    >> I think this would be a step back after commit
    >> c50cbb05a05cf1f9ca3592272eff053c847727d8. Which exported default
    >> topology information, in case the architecture does not provide these
    >> information.
    >
    > I am fine with exporting default topology information for all
    > architectures.
    >
    > I just wanted to avoid pollution of sysfs with useless information
    > when this information is not provided on an architecture.
    >
    > Further thoughts -- e.g. concerning the MULTI_NODE_CPU config option?
    >
    > If I provide defaults for cpu_node_id, cpu_node_siblings etc. the
    > config option becomes rather useless and I'll remove it.
    Exactly ;-)

    The interface to the exported API should not depend on config options.
    Only the kernel version number should indicate, whether the cpu_node
    information is available or not.

    Thanks,
    Bert
    >
    >
    > Regards,
    > Andreas
    >
    >
    >


    \
     
     \ /
      Last update: 2009-06-02 18:23    [W:0.021 / U:0.088 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site