lkml.org 
[lkml]   [2009]   [Jun]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/5] TOMOYO: Clarify lock protected section.
On Tue, 2 Jun 2009, Tetsuo Handa wrote:

> I intended to help reviewers to visualize the range of protected section
> at a glance. But if reviewers feel noisy, I can remove these markers.

The lock functions act as annotations, you don't need to add any more.

Only add comments if the code is not obvious, but also first ask whether
this might mean that there's something wrong.

--
James Morris
<jmorris@namei.org>


\
 
 \ /
  Last update: 2009-06-02 07:11    [from the cache]
©2003-2011 Jasper Spaans