Messages in this thread | | | Subject | Re: [PATCH] Add new TAINT_KSPLICE flag for when a Ksplice update has been loaded. | From | Peter Zijlstra <> | Date | Fri, 19 Jun 2009 22:11:47 +0200 |
| |
On Fri, 2009-06-19 at 15:57 -0400, Tim Abbott wrote: > Distributions and kerneloops.org have requested that the Ksplice > rebootless update system taint the kernel the first time that a > Ksplice update is installed, in order to assist with bug triage. > > Ksplice uses a new taint flag, TAINT_KSPLICE, displayed as 'K', for > this purpose. > > We would like to confirm that this use of taint meets with the > community's approval and get this taint flag registered in mainline. > > Signed-off-by: Tim Abbott <tabbott@ksplice.com>
Since all of ksplice is still out-of-tree, it seems to me this taint should be too.
Just add it to the ksplice patch. That way it will get into mainline if/when ksplice will.
> --- > include/linux/kernel.h | 1 + > kernel/panic.c | 2 ++ > 2 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/include/linux/kernel.h b/include/linux/kernel.h > index c5a71c3..be77585 100644 > --- a/include/linux/kernel.h > +++ b/include/linux/kernel.h > @@ -330,6 +330,7 @@ extern enum system_states { > #define TAINT_OVERRIDDEN_ACPI_TABLE 8 > #define TAINT_WARN 9 > #define TAINT_CRAP 10 > +#define TAINT_KSPLICE 11 > > extern void dump_stack(void) __cold; > > diff --git a/kernel/panic.c b/kernel/panic.c > index 984b3ec..c2ea780 100644 > --- a/kernel/panic.c > +++ b/kernel/panic.c > @@ -160,6 +160,7 @@ static const struct tnt tnts[] = { > { TAINT_OVERRIDDEN_ACPI_TABLE, 'A', ' ' }, > { TAINT_WARN, 'W', ' ' }, > { TAINT_CRAP, 'C', ' ' }, > + { TAINT_KSPLICE, 'K', ' ' }, > }; > > /** > @@ -176,6 +177,7 @@ static const struct tnt tnts[] = { > * 'A' - ACPI table overridden. > * 'W' - Taint on warning. > * 'C' - modules from drivers/staging are loaded. > + * 'K' - A Ksplice update has been loaded. > * > * The string is overwritten by the next call to print_taint(). > */
| |