Messages in this thread | | | From | Jonathan Brassow <> | Subject | Re: [dm-devel] [PATCH -next] dm: dm-log-userspace depends on NET | Date | Fri, 19 Jun 2009 13:31:39 -0500 |
| |
Thanks, I've pulled this into my patch.
brassow
On Jun 19, 2009, at 12:38 PM, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com> > > DM_LOG_USERSPACE selects CONNECTOR, but when NET is not enabled, > this is > useless and the build fails, so make DM_LOG_USERSPACE depend on NET. > > ERROR: "netlink_has_listeners" [drivers/connector/cn.ko] undefined! > ERROR: "proc_net_fops_create" [drivers/connector/cn.ko] undefined! > ERROR: "netlink_kernel_create" [drivers/connector/cn.ko] undefined! > ERROR: "proc_net_remove" [drivers/connector/cn.ko] undefined! > ERROR: "netlink_kernel_release" [drivers/connector/cn.ko] undefined! > ERROR: "init_net" [drivers/connector/cn.ko] undefined! > ERROR: "__alloc_skb" [drivers/connector/cn.ko] undefined! > ERROR: "netlink_broadcast" [drivers/connector/cn.ko] undefined! > ERROR: "kfree_skb" [drivers/connector/cn.ko] undefined! > ERROR: "skb_put" [drivers/connector/cn.ko] undefined! > > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> > Cc: Jonathan Brassow <dm-devel@redhat.com> > Cc: dm-devel@redhat.com > --- > drivers/md/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- linux-next-20090619.orig/drivers/md/Kconfig > +++ linux-next-20090619/drivers/md/Kconfig > @@ -233,7 +233,7 @@ config DM_MIRROR > > config DM_LOG_USERSPACE > tristate "Mirror userspace logging (EXPERIMENTAL)" > - depends on DM_MIRROR && EXPERIMENTAL > + depends on DM_MIRROR && EXPERIMENTAL && NET > select CONNECTOR > ---help--- > The userspace logging module provides a mechanism for > > > > -- > ~Randy > LPC 2009, Sept. 23-25, Portland, Oregon > http://linuxplumbersconf.org/2009/ > > -- > dm-devel mailing list > dm-devel@redhat.com > https://www.redhat.com/mailman/listinfo/dm-devel
| |