lkml.org 
[lkml]   [2009]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2] slab,slub: ignore __GFP_WAIT if we're booting or suspending
    Hi!

    >
    > As explained by Benjamin Herrenschmidt:
    >
    > Oh and btw, your patch alone doesn't fix powerpc, because it's missing
    > a whole bunch of GFP_KERNEL's in the arch code... You would have to
    > grep the entire kernel for things that check slab_is_available() and
    > even then you'll be missing some.
    >
    > For example, slab_is_available() didn't always exist, and so in the
    > early days on powerpc, we used a mem_init_done global that is set form
    > mem_init() (not perfect but works in practice). And we still have code
    > using that to do the test.
    >
    > Therefore, ignore __GFP_WAIT in the slab allocators if we're booting or
    > suspending.

    Ok... GFP_KERNEL allocations normally don't fail; now they
    will. Should we at least force access to atomic reserves in such case?
    Pavel
    --
    (english) http://www.livejournal.com/~pavelmachek
    (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


    \
     
     \ /
      Last update: 2009-06-19 17:01    [W:0.023 / U:119.992 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site