Messages in this thread | | | Date | Fri, 19 Jun 2009 13:03:52 +0800 | From | Li Zefan <> | Subject | Re: [PATCH 2/2] tracing/filters: remove error messages |
| |
Tom Zanussi wrote: > On Thu, 2009-06-18 at 09:17 +0800, Li Zefan wrote: >> Frederic Weisbecker wrote: >>> On Wed, Jun 17, 2009 at 04:47:15PM +0800, Li Zefan wrote: >>>> Now we restore original filter is the new one can't be applied, >>>> and no long show error messages, so we can remove them totally. >>> Why? >>> These messages are very powerful to point a user to its mistakes >>> in filters syntaxes or semantics. >>> >>> I really think we are removing a very useful feature in this patch. >>> >> I think it's better done by providing a user-space program/script. >> >> So what's the criterion to decide what should be in kernel and >> what should be in user-space? >> > > I thought there wasn't supposed to be any userspace for non-binary > tracing.
This is a good point, and I agree on this direction.
> If there is, then yeah, you can get rid of the error messages > in the kernel because your userspace program can arrange to never submit > an erroneous filter. >
| |