[lkml]   [2009]   [Jun]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 12/16] x86, mce: squash mce_intel.c into therm_throt.c
On Thu, Jun 18, 2009 at 3:31 PM, Hidetoshi
Seto<> wrote:
> huang ying wrote:
>> 2009/6/15 Hidetoshi Seto <>:
>>> move intel_init_thermal() into therm_throt.c
>>> Signed-off-by: Hidetoshi Seto <>
>>> ---
>>>  arch/x86/kernel/cpu/mcheck/Makefile      |    2 +-
>>>  arch/x86/kernel/cpu/mcheck/mce_intel.c   |   73 ------------------------------
>>>  arch/x86/kernel/cpu/mcheck/therm_throt.c |   66 +++++++++++++++++++++++++++
>>>  3 files changed, 67 insertions(+), 74 deletions(-)
>>>  delete mode 100644 arch/x86/kernel/cpu/mcheck/mce_intel.c
>> Why we need this patch? I think the design principle behind MCE is to
>> separate vendor/cpu specific code into different files. At least
>> #ifdef CONFIG_X86_MCE_INTEL should be used around moved code.
> Because at this time there are no vendor other than Intel that uses
> thermal codes here.  I don't know much about AMD, whether there are
> any plan to implement AMD specific thermal codes or not, and why they
> have to make such specific thing here in future (patent?).
> You can pull out "codes may not be shared" from therm_throt.c and
> put it again into mce_intel.c (that was mce_intel_64.c).  But I
> believe it is not needed now, until another code is available.
> Or you can rename therm_throt.c to thermal_intel.c or so for a while.

I think thermal_intel.c is better.

Best Regards,
Huang Ying
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2009-06-18 10:09    [W:0.061 / U:0.624 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site