lkml.org 
[lkml]   [2009]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH -tip] x86: hw_breakpoint.c arch_check_va_in_kernelspace and hw_breakpoint_handler should be static
    From
    Date

    arch_check_va_in_kernelspace() and hw_breakpoint_handler() is used only by same file so it should be static.

    Also fixed non-ANSI function declaration of function 'arch_uninstall_thread_hw_breakpoint'

    Fixed following sparse warnings :
    arch/x86/kernel/hw_breakpoint.c:124:42: warning: non-ANSI function declaration of function 'arch_uninstall_thread_hw_breakpoint'
    arch/x86/kernel/hw_breakpoint.c:169:5: warning: symbol 'arch_check_va_in_kernelspace' was not declared. Should it be static?
    arch/x86/kernel/hw_breakpoint.c:313:15: warning: symbol 'hw_breakpoint_handler' was not declared. Should it be static?

    Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
    ---
    arch/x86/kernel/hw_breakpoint.c | 6 +++---
    1 files changed, 3 insertions(+), 3 deletions(-)

    diff --git a/arch/x86/kernel/hw_breakpoint.c b/arch/x86/kernel/hw_breakpoint.c
    index 6945147..47869d8 100644
    --- a/arch/x86/kernel/hw_breakpoint.c
    +++ b/arch/x86/kernel/hw_breakpoint.c
    @@ -121,7 +121,7 @@ void arch_install_thread_hw_breakpoint(struct task_struct *tsk)
    /*
    * Install the debug register values for just the kernel, no thread.
    */
    -void arch_uninstall_thread_hw_breakpoint()
    +void arch_uninstall_thread_hw_breakpoint(void)
    {
    /* Clear the user-space portion of debugreg7 by setting only kdr7 */
    set_debugreg(kdr7, 7);
    @@ -166,7 +166,7 @@ int arch_check_va_in_userspace(unsigned long va, u8 hbp_len)
    /*
    * Check for virtual address in kernel space.
    */
    -int arch_check_va_in_kernelspace(unsigned long va, u8 hbp_len)
    +static int arch_check_va_in_kernelspace(unsigned long va, u8 hbp_len)
    {
    unsigned int len;

    @@ -310,7 +310,7 @@ void arch_flush_thread_hw_breakpoint(struct task_struct *tsk)
    * NOTIFY_STOP returned for all other cases
    *
    */
    -int __kprobes hw_breakpoint_handler(struct die_args *args)
    +static int __kprobes hw_breakpoint_handler(struct die_args *args)
    {
    int i, cpu, rc = NOTIFY_STOP;
    struct hw_breakpoint *bp;
    --
    1.6.0.6




    \
     
     \ /
      Last update: 2009-06-17 11:17    [W:0.024 / U:118.708 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site