lkml.org 
[lkml]   [2009]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC 2/7] crypto: Use GHASH digest algorithm in GCM
From
Date
On Thu, 2009-06-18 at 04:47 +0800, Sebastian Andrzej Siewior wrote:
> * Huang Ying | 2009-06-11 15:10:28 [+0800]:
>
> >Remove the dedicated GHASH implementation in GCM, and uses the GHASH
> >digest algorithm instead. This will make GCM uses hardware accelerated
> >GHASH implementation automatically if available.
> >
> >ahash instead of shash interface is used, because some hardware
> >accelerated GHASH implementation needs asynchronous interface.
> The outside interface is also async so this should work.
>
> >Signed-off-by: Huang Ying <ying.huang@intel.com>
> >
> >@@ -796,14 +996,15 @@ static int __init crypto_gcm_module_init
> > if (err)
> > goto out_undo_gcm;
> >
> >-out:
> >- return err;
> >+ return 0;
> >
> > out_undo_gcm:
> > crypto_unregister_template(&crypto_gcm_tmpl);
> > out_undo_base:
> > crypto_unregister_template(&crypto_gcm_base_tmpl);
> >- goto out;
> >+out:
> >+ kfree(gcm_zeroes);
> >+ return err;
> > }
> >
> > static void __exit crypto_gcm_module_exit(void)
> here you are leaking gcm_zeroes

Yes. I will change this. Thank you.

Best Regards,
Huang Ying



\
 
 \ /
  Last update: 2009-06-18 04:13    [W:0.081 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site